Skip to content

fix: agent error reporting and handling #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: agent error reporting and handling #93

wants to merge 1 commit into from

Conversation

fioan89
Copy link
Collaborator

@fioan89 fioan89 commented Apr 17, 2025

  • if workspace or agent start with error, we report the workspace as started with errors and highlight the text with red.
  • the workspace is still marked as reachable even though it is unhealthy but we no longer connect automatically to the workspace via ssh when user selects the workspace from the env list.

@fioan89
fix: agent error reporting and handling
a264930 
- if workspace or agent start with error, we report the workspace as started with errors and highlight
  the text with red.
- the workspace is still marked as reachable even though it is unhealthy but we no longer connect
  automatically to the workspace via ssh when user selects the workspace from the env list.
@fioan89 fioan89 requested review from matifali, f0ssel and bpmct April 17, 2025 21:53
@fioan89
Copy link
Collaborator Author

fioan89 commented Apr 17, 2025

We now highlight in red that the workspace is started but it is not healthy.

Screenshot 2025-04-18 at 00 40 46

matifali
matifali approved these changes Apr 21, 2025
View reviewed changes
CHANGELOG.md
@@ -6,6 +6,10 @@

- support for using proxies. Proxy authentication is not yet supported.

### Changed

- connections to the workspace are no longer established automatically after agent started with error.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only apply when there are errors. A healthy workspace should still auto-connect. Right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, healty workspaces will continue to auto-connect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matifali matifali matifali approved these changes

@f0ssel f0ssel f0ssel approved these changes

@bpmct bpmct Awaiting requested review from bpmct

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fioan89 @matifali @f0ssel